Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: do not assume that service record of redirector is present/has url #567

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

yarikoptic
Copy link
Member

Closes #566

Result of dandi/redirector#40

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #567 (b887ef7) into master (04df20d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          62       62           
  Lines        6510     6511    +1     
=======================================
+ Hits         5448     5449    +1     
  Misses       1062     1062           
Flag Coverage Δ
unittests 83.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/utils.py 80.32% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04df20d...b887ef7. Read the comment docs.

@yarikoptic yarikoptic merged commit 4073da2 into master Apr 13, 2021
@yarikoptic yarikoptic deleted the bf-service-url branch April 13, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during dandi upload
1 participant