-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default dandi instance to dandi-api based on redirector #565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 83.70% 83.73% +0.02%
==========================================
Files 62 62
Lines 6530 6559 +29
==========================================
+ Hits 5466 5492 +26
- Misses 1064 1067 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gui=server_info["services"]["webui"]["url"], | ||
redirector=redirector_url, | ||
api=server_info["services"]["api"]["url"], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we please retain robustness of .get
to provide None
? or what would be the benefit of client crashing here if redirector again just drops a field instead of explicitly annotating with null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! next one to touch this piece of code is to reduce duplication. Let's proceed
besides one comment (I would prefer |
Closes #541.