Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to migrate2newschema #515

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Conversation

djarecka
Copy link
Member

using deepcopy(data) in migrate2newschema, so it doesn't change the original data
closes #514

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #515 (e781e29) into master (8f9bff1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   82.64%   82.65%   +0.01%     
==========================================
  Files          59       59              
  Lines        6107     6112       +5     
==========================================
+ Hits         5047     5052       +5     
  Misses       1060     1060              
Flag Coverage Δ
unittests 82.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/metadata.py 77.48% <100.00%> (+0.05%) ⬆️
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9bff1...e781e29. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks kosher - good to merge if tests remain green

@yarikoptic
Copy link
Member

Thank you @djarecka !

@yarikoptic yarikoptic merged commit c370914 into dandi:master Mar 27, 2021
@yarikoptic
Copy link
Member

Damn forgot to add a label for auto

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate2newschema quietly changes argument
2 participants