Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate uploads before digesting #495

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Validate uploads before digesting #495

merged 1 commit into from
Mar 24, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 24, 2021

Closes #492.

@jwodder jwodder added the patch Increment the patch version when merged label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #495 (5e880b2) into master (089101e) will not change coverage.
The diff coverage is 81.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files          59       59           
  Lines        6054     6054           
=======================================
  Hits         5009     5009           
  Misses       1045     1045           
Flag Coverage Δ
unittests 82.73% <81.25%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/upload.py 75.71% <81.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089101e...5e880b2. Read the comment docs.

@yarikoptic
Copy link
Member

Looks kosher, thank you @jwodder !

@yarikoptic yarikoptic merged commit 446f774 into master Mar 24, 2021
@yarikoptic yarikoptic deleted the gh-492 branch March 24, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload: move digestion after validation
2 participants