Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandi ls: Error if --schema is given with remote resource of different version #489

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 24, 2021

Closes #485.

@jwodder jwodder added the patch Increment the patch version when merged label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #489 (5298337) into master (b47e06e) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   64.83%   64.89%   +0.06%     
==========================================
  Files          59       59              
  Lines        5991     5993       +2     
==========================================
+ Hits         3884     3889       +5     
+ Misses       2107     2104       -3     
Flag Coverage Δ
unittests 64.89% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_ls.py 60.00% <0.00%> (-0.74%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47e06e...5298337. Read the comment docs.

@yarikoptic
Copy link
Member

Thanks, let's proceed

@yarikoptic yarikoptic merged commit 078e655 into master Mar 24, 2021
@yarikoptic yarikoptic deleted the gh-485 branch March 24, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema option has no effect
2 participants