-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script for generating S3 versioned file stats #473
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dfcb93b
Added script for generating S3 versioned file stats
jwodder 3d246b8
Track & report different types of files separately
jwodder b1d3851
Fix double-reporting bug
jwodder a34e962
Humanize total sizes
jwodder e44fa8c
Add --exclude option
jwodder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,184 @@ | ||
#!/usr/bin/env python3 | ||
|
||
# Assumptions made by this code: | ||
# - list_object_versions sorts all versions (including delete markers) by key | ||
# (in ascending order) and last modified date (in descending order, sometimes | ||
# with consecutive equal timestamps) and returns them in chunks of 1000 (by | ||
# default), with each chunk divided into proper versions and delete markers. | ||
# - Objects that have been deleted will have a delete marker as their latest | ||
# version and at least one proper version dated before that. | ||
|
||
__requires__ = ["boto3", "click >= 7.0", "humanize"] | ||
|
||
from bisect import bisect | ||
from datetime import datetime | ||
import re | ||
import sys | ||
from typing import List, NamedTuple, Tuple | ||
from urllib.parse import urlparse | ||
|
||
import boto3 | ||
from botocore import UNSIGNED | ||
from botocore.client import Config | ||
import click | ||
from humanize import naturalsize | ||
|
||
|
||
class Version(NamedTuple): | ||
bucket: str | ||
key: str | ||
version_id: str | ||
size: int | ||
last_modified: datetime | ||
|
||
@classmethod | ||
def from_data(cls, bucket, data): | ||
return cls( | ||
bucket=bucket, | ||
key=data["Key"], | ||
version_id=data["VersionId"], | ||
size=data["Size"], | ||
last_modified=data["LastModified"], | ||
) | ||
|
||
@property | ||
def key_url(self): | ||
return f"s3://{self.bucket}/{self.key}" | ||
|
||
@property | ||
def url(self): | ||
return f"s3://{self.bucket}/{self.key}?versionId={self.version_id}" | ||
|
||
def __str__(self): | ||
return f"{self.url} {self.size}" | ||
|
||
|
||
class BucketStats: | ||
def __init__(self, bucket, prefix, list_files=False, stat=("all",), exclude=()): | ||
self.bucket: str = bucket | ||
self.prefix: str = prefix | ||
self.list_files: bool = list_files | ||
self.stat: Tuple[str, ...] = stat | ||
self.exclude: Tuple[str, ...] = exclude | ||
#: Versions of the current key | ||
self.versions: List[Version] = [] | ||
# Deleted keys, in ascending order: | ||
self.deleted: List[str] = [] | ||
self.qtys = { | ||
"all": 0, | ||
"visible": 0, | ||
"invisible": 0, | ||
"old": 0, | ||
} | ||
self.sizes = { | ||
"all": 0, | ||
"visible": 0, | ||
"invisible": 0, | ||
"old": 0, | ||
} | ||
self.found_any = False | ||
|
||
def run(self): | ||
# Use s3 anonymously/without credentials: | ||
client = boto3.client("s3", config=Config(signature_version=UNSIGNED)) | ||
for page in client.get_paginator("list_object_versions").paginate( | ||
Bucket=self.bucket, Prefix=self.prefix | ||
): | ||
# TODO: Filter out keys that ends with slashes? | ||
for dm in page.get("DeleteMarkers", []): | ||
if dm["IsLatest"]: | ||
self.mark_deleted(dm["Key"]) | ||
for v in page["Versions"]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: it seems to correctly work out the keys which were added before versioning was turned on -- look at 1version-nonversioned1.txt and 2versions-nonversioned1.txt . GREAT!(git)lena:~/proj/dandi/dandi-cli-master[gh-470]git
$> tools/s3-gc-stats --stat visible --list s3://datalad-test0-versioned
s3://datalad-test0-versioned/1version-nonversioned1.txt?versionId=null 8
s3://datalad-test0-versioned/1version-removed-recreated.txt?versionId=vurmCZo5d3.iAzTV.YAfTcMr.LDVjQIK 8
s3://datalad-test0-versioned/2versions-nonversioned1.txt?versionId=V4Dqhu0QTEtxmvoNkCHGrjVZVomR1Ryo 8
s3://datalad-test0-versioned/2versions-nonversioned1.txt_sameprefix?versionId=QUOLbSrBHBmU3UNeEvdfcX2puqRffH9l 8
s3://datalad-test0-versioned/2versions-removed-recreated.txt?versionId=bBVSCB4MdBOeEXDQ2KwrjtrevpwFabaY 8
s3://datalad-test0-versioned/2versions-removed-recreated.txt_sameprefix?versionId=cfTdf3N8exZLFg.KcW5szQKrFNLUyCu1 8
s3://datalad-test0-versioned/3versions-allversioned.txt?versionId=Kvuind11HZh._dCPaDAb0OY9dRrQoTMn 8
s3://datalad-test0-versioned/3versions-allversioned.txt_sameprefix?versionId=Mvsc4FgJWc6gExwSw1d6wsLrnk6wdDVa 8
Visible files: 8 / Size: 64 (64 Bytes)
1 66166.....................................:Wed 17 Mar 2021 10:34:34 AM EDT:.
(git)lena:~/proj/dandi/dandi-cli-master[gh-470]git
$> tools/s3-gc-stats --stat invisible --list s3://datalad-test0-versioned
s3://datalad-test0-versioned/1version-removed-recreated.txt?versionId=B7cP2PKGRNeRZ7EktWN82UnUaGjb9dh_ 8
s3://datalad-test0-versioned/1version-removed.txt?versionId=eZ5Hgwo8azfBv3QT7aW9dmm2sbLUY.QP 8
s3://datalad-test0-versioned/2versions-nonversioned1.txt?versionId=null 8
s3://datalad-test0-versioned/2versions-removed-recreated.txt?versionId=zwW0b567gYO3puJeLMZsOmETqowJnv6l 8
s3://datalad-test0-versioned/3versions-allversioned.txt?versionId=b.qCuh7Sg58VIYj8TVHzbRS97EvejzEl 8
s3://datalad-test0-versioned/3versions-allversioned.txt?versionId=pNsV5jJrnGATkmNrP8.i_xNH6CY4Mo5s 8
Invisible files: 6 / Size: 48 (48 Bytes)
|
||
self.add_version(v) | ||
self.end_key() | ||
for rtype in self.stat: | ||
print( | ||
f"{rtype.title()} files: {self.qtys[rtype]}", | ||
"/", | ||
f"Size: {self.sizes[rtype]} ({naturalsize(self.sizes[rtype])})", | ||
) | ||
|
||
def add_version(self, data): | ||
v = Version.from_data(self.bucket, data) | ||
if self.versions: | ||
if self.versions[-1].key == v.key: | ||
assert ( | ||
self.versions[-1].last_modified >= v.last_modified | ||
), f"Versions for key {v.key!r} not in reverse chronological order" | ||
else: | ||
assert self.versions[-1].key < v.key, ( | ||
"Keys not in lexicographic order;" | ||
f" {self.versions[-1].key!r} listed before {v.key!r}" | ||
) | ||
self.end_key() | ||
self.versions.append(v) | ||
|
||
def mark_deleted(self, key): | ||
if self.deleted: | ||
assert ( | ||
self.deleted[-1] < key | ||
), f"DeleteMarkers not in lexicographic order; {self.deleted[-1]} listed before {key}" | ||
self.deleted.append(key) | ||
|
||
def end_key(self): | ||
if self.versions: | ||
key = self.versions[0].key | ||
if self.deleted: | ||
i = bisect(self.deleted, key) | ||
# Error/warn if i>1? | ||
deleted = i > 0 and self.deleted[i - 1] == key | ||
del self.deleted[:i] | ||
else: | ||
deleted = False | ||
if deleted: | ||
self.report({"all", "invisible"}, self.versions) | ||
else: | ||
self.report({"all", "visible"}, self.versions[:1]) | ||
self.report({"all", "old", "invisible"}, self.versions[1:]) | ||
self.versions = [] | ||
|
||
def report(self, rtypes, versions): | ||
if not versions: | ||
return | ||
if any(re.search(rgx, versions[0].key_url) for rgx in self.exclude): | ||
return | ||
if rtypes.intersection(self.stat): | ||
for v in versions: | ||
self.found_any = True | ||
if self.list_files: | ||
print(v) | ||
for t in rtypes: | ||
self.qtys[t] += 1 | ||
self.sizes[t] += v.size | ||
|
||
|
||
@click.command() | ||
@click.option("--exclude", metavar="URLREGEX", multiple=True) | ||
@click.option("--fail-if-any", is_flag=True) | ||
@click.option("--list", "list_files", is_flag=True) | ||
@click.option( | ||
"--stat", | ||
type=click.Choice(["all", "visible", "invisible", "old"]), | ||
multiple=True, | ||
default=["all"], | ||
) | ||
@click.argument("url") | ||
def main(stat, list_files, fail_if_any, url, exclude): | ||
bucket, prefix = parse_s3_url(url) | ||
stats = BucketStats( | ||
bucket, prefix, list_files=list_files, stat=stat, exclude=exclude | ||
) | ||
stats.run() | ||
if fail_if_any and stats.found_any: | ||
sys.exit(1) | ||
|
||
|
||
def parse_s3_url(url): | ||
parts = urlparse(url, allow_fragments=False) | ||
if parts.scheme != "s3": | ||
raise ValueError(f"not an S3 URL: {url}") | ||
return (parts.netloc, parts.path.lstrip("/")) | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: these assumptions seems to be validated in the code below: https://github.com/dandi/dandi-cli/pull/473/files#diff-c840778a73d440599aee9be998e0b555e84831c627e589f54439e8d3f2819295R103 . Great!