Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between pre- and post-validation when uploading #420

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 24, 2021

This PR changes the names of the "validation" statuses when uploading to "pre-validation" (done client-side before uploading) and "post-validation" (done server-side after uploading) so that one can more accurately tell what state an upload is in.

@jwodder jwodder added the patch Increment the patch version when merged label Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #420 (71619d3) into master (fc5de49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          55       55           
  Lines        5679     5679           
=======================================
  Hits         4671     4671           
  Misses       1008     1008           
Flag Coverage Δ
unittests 82.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 87.28% <100.00%> (ø)
dandi/upload.py 75.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5de49...71619d3. Read the comment docs.

@yarikoptic
Copy link
Member

I even wonder if we should make it even more to the point

  • metadata check
  • upload check

Using check instead of validation since shorter. Wdyt?

@jwodder
Copy link
Member Author

jwodder commented Feb 24, 2021

@yarikoptic I feel like "upload check" doesn't really convey much meaning. Also, "metadata check" is the same length as "pre-validation".

@yarikoptic
Copy link
Member

I meant that "metadata check" would be shorter than "metadata validation". But ok -- let's proceed with pre/post.

@yarikoptic yarikoptic merged commit 1cc2043 into master Feb 24, 2021
@yarikoptic yarikoptic deleted the pre-post-valid branch February 24, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants