Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache file digests and check for change in digest when uploading #391

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 16, 2021

Closes #389.

This PR reverts #388.

@jwodder jwodder added the patch Increment the patch version when merged label Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #391 (49fbcf0) into master (48679c6) will decrease coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   82.39%   82.38%   -0.01%     
==========================================
  Files          55       55              
  Lines        5708     5711       +3     
==========================================
+ Hits         4703     4705       +2     
- Misses       1005     1006       +1     
Flag Coverage Δ
unittests 82.38% <93.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 87.21% <87.50%> (-0.52%) ⬇️
dandi/support/digests.py 100.00% <100.00%> (ø)
dandi/upload.py 76.00% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48679c6...49fbcf0. Read the comment docs.

@yarikoptic
Copy link
Member

Looks good, thank you @jwodder!

@yarikoptic yarikoptic merged commit ee2e282 into master Feb 16, 2021
@yarikoptic yarikoptic deleted the gh-389 branch February 16, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fscache checksum computation on a file
2 participants