Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give validate command a --schema VERSION option for validating assets and dandiset.yaml #379

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 10, 2021

Closes #375.

@jwodder jwodder added the patch Increment the patch version when merged label Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #379 (e45b171) into master (351bd29) will decrease coverage by 0.27%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   83.14%   82.87%   -0.28%     
==========================================
  Files          55       55              
  Lines        5636     5663      +27     
==========================================
+ Hits         4686     4693       +7     
- Misses        950      970      +20     
Flag Coverage Δ
unittests 82.87% <38.46%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/validate.py 57.33% <31.42%> (-22.26%) ⬇️
dandi/cli/cmd_validate.py 87.50% <100.00%> (+0.40%) ⬆️
dandi/dandiapi.py 88.47% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351bd29...e45b171. Read the comment docs.

@jwodder jwodder changed the title Give validate command a --schema VERSION option for validating assets Give validate command a --schema VERSION option for validating assets and dandiset.yaml Feb 10, 2021
@jwodder jwodder marked this pull request as ready for review February 10, 2021 19:00
@yarikoptic yarikoptic merged commit efc76ec into master Feb 12, 2021
@yarikoptic yarikoptic deleted the gh-375 branch February 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate: add an option to force validation against current (new, API) schema
2 participants