Add include_metadata=False parameter to asset-listing DandiAPIClient methods
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 83.02% 83.14% +0.11%
==========================================
Files 55 55
Lines 5609 5636 +27
==========================================
+ Hits 4657 4686 +29
+ Misses 952 950 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
For girder instances we do get metadata, and we get metadata for the dandiset. So for consistency and better utility of "dandi ls" - always request metadata for api server in navigate_url
to not crash if for some reason API did not provide metadata for an asset. We will rely on tests to ensure that API server provides, but otherwise - not crash
yarikoptic
approved these changes
Feb 10, 2021
dandi/dandiapi.py
Outdated
| if include_metadata: | ||
| asset["metadata"] = self.get_asset( | ||
| dandiset_id, version, asset["uuid"] | ||
| )["metadata"] |
There was a problem hiding this comment.
I would prefer to be resilient and rely on tests to catch if behavior of the api server would change: please get_asset, and only if metadata is within the record - assign to the asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #376.