Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle uploading already-present files in new API #347

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 26, 2021

Closes #345.

@jwodder jwodder added the patch Increment the patch version when merged label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #347 (034d3e1) into master (53da9e9) will increase coverage by 1.66%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   82.15%   83.82%   +1.66%     
==========================================
  Files          55       55              
  Lines        5454     5935     +481     
==========================================
+ Hits         4481     4975     +494     
+ Misses        973      960      -13     
Flag Coverage Δ
unittests 83.82% <98.11%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 86.79% <75.00%> (+0.58%) ⬆️
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)
dandi/tests/test_upload.py 93.30% <100.00%> (+3.94%) ⬆️
dandi/upload.py 79.78% <100.00%> (+9.93%) ⬆️
dandi/download.py 84.86% <0.00%> (-0.33%) ⬇️
dandi/metadata.py 82.07% <0.00%> (+3.04%) ⬆️
dandi/models.py 89.37% <0.00%> (+4.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53da9e9...034d3e1. Read the comment docs.

@jwodder
Copy link
Member Author

jwodder commented Jan 28, 2021

The PR includes the requested tests, but several of them currently fail (and are marked xfailing) due to #345 (comment) and dandi/dandi-archive#70 not yet being addressed.

@yarikoptic
Copy link
Member

yarikoptic commented Jan 29, 2021

Thank you @jwodder . I guess we are just doomed to wait for dandi/dandi-archive#70 to get implemented (outstanding PR: dandi/dandi-archive#75)

@yarikoptic
Copy link
Member

there is dandisets_versions_assets_delete endpoint now, so it is possible to proceed

@jwodder
Copy link
Member Author

jwodder commented Jan 29, 2021

Found another blocking bug: dandi/dandi-archive#76

@yarikoptic
Copy link
Member

dandi/dandi-archive#76 was addressed, so should be possible to proceed forward.

@jwodder
Copy link
Member Author

jwodder commented Feb 2, 2021

A new blocking bug: dandi/dandi-archive#81

@yarikoptic
Copy link
Member

I have just merged dandi/dandi-archive#84 which should provide remedy (even if later to be refactored) so we could proceed here.

@jwodder jwodder marked this pull request as ready for review February 9, 2021 13:51
@jwodder
Copy link
Member Author

jwodder commented Feb 9, 2021

@yarikoptic Tests finally pass.

@yarikoptic
Copy link
Member

awesome -- let's proceed!

@yarikoptic yarikoptic merged commit 0bda197 into master Feb 9, 2021
@yarikoptic yarikoptic deleted the gh-345 branch February 9, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dandi-api: upload - (re)introduce handling of existing files
2 participants