-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: devel upload dandiset metadata #341
Conversation
…sion later might just be removed when all metadata is compliant and Dandiset does not need to do identifier guessing etc
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 81.78% 81.97% +0.18%
==========================================
Files 55 55
Lines 5341 5375 +34
==========================================
+ Hits 4368 4406 +38
+ Misses 973 969 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
So we could easily upload/migrate dandisets for testing etc
otherwise it can still be a str and thus check would crash there
…, use in send_request For some reason those headers in the session are "lost" whenever we use pyout and its parallelization: so if I use upload - I get 401. This way we would always use that token in every request
a3d2aa5
to
d83004e
Compare
force pushed updates |
@yarikoptic How do I mark this PR as "approved"? Or should I just go ahead and merge it? |
Click on green "Review changes" in "Files changed" tab, choose "Approve"
In general/future -- you are most welcome to do just that if satisfied, unless multiple reviewers were requested and we are still waiting on feedback. Meanwhile, I will beat you to it, and will click Merge ;) |
Closes #339
ref dandi/dandi-archive#66 on not forgetting the trailing
/
TODO