Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: devel upload dandiset metadata #341

Merged
merged 6 commits into from
Jan 29, 2021

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Jan 25, 2021

Closes #339
ref dandi/dandi-archive#66 on not forgetting the trailing /

TODO

  • test

…sion

later might just be removed when all metadata is compliant and Dandiset
does not need to do identifier guessing etc
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #341 (d83004e) into master (30e0695) will increase coverage by 0.18%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   81.78%   81.97%   +0.18%     
==========================================
  Files          55       55              
  Lines        5341     5375      +34     
==========================================
+ Hits         4368     4406      +38     
+ Misses        973      969       -4     
Flag Coverage Δ
unittests 81.97% <92.10%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 86.20% <80.00%> (+2.20%) ⬆️
dandi/upload.py 69.84% <88.88%> (+0.36%) ⬆️
dandi/dandiset.py 88.31% <90.00%> (+3.23%) ⬆️
dandi/cli/cmd_upload.py 88.88% <100.00%> (+0.65%) ⬆️
dandi/tests/test_upload.py 89.36% <100.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e0695...d83004e. Read the comment docs.

dandi/dandiapi.py Outdated Show resolved Hide resolved
dandi/upload.py Outdated Show resolved Hide resolved
So we could easily upload/migrate dandisets for testing etc
otherwise it can still be a str and thus check would crash there
…, use in send_request

For some reason those headers in the session are "lost" whenever we use
pyout and its parallelization: so if I use  upload - I get 401.  This way
we would always use that token in every request
@yarikoptic yarikoptic force-pushed the enh-devel-upload-dandiset-metadata branch from a3d2aa5 to d83004e Compare January 26, 2021 17:43
@yarikoptic
Copy link
Member Author

force pushed updates

@jwodder
Copy link
Member

jwodder commented Jan 29, 2021

@yarikoptic How do I mark this PR as "approved"? Or should I just go ahead and merge it?

@yarikoptic
Copy link
Member Author

@yarikoptic How do I mark this PR as "approved"?

Click on green "Review changes" in "Files changed" tab, choose "Approve"

Or should I just go ahead and merge it?

In general/future -- you are most welcome to do just that if satisfied, unless multiple reviewers were requested and we are still waiting on feedback. Meanwhile, I will beat you to it, and will click Merge ;)

@yarikoptic yarikoptic merged commit c13640f into master Jan 29, 2021
@yarikoptic yarikoptic deleted the enh-devel-upload-dandiset-metadata branch January 29, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload --upload-dandiset-yaml: to ease/automate migration - allow for upload of (migrated) dandiset.yaml
2 participants