Install hdf5 for Python 3.9 tests #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 81.72% 81.72%
=======================================
Files 54 54
Lines 4979 4979
=======================================
Hits 4069 4069
Misses 910 910
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Awesome! This would close #313 |
|
h5py is installing fine now under Python 3.9; the current test failures are a separate issue, resolved by #314. |
|
Thanks! I have merged #314 |
|
Could you please rebase so we get a clean rerun of workflows with tests fixed? |
|
@yarikoptic Rebased. |
jwodder
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On December 9, hdmf released a new version that restricted its h5py dependency version range to
<3,>=2.9; as a result, installing dandi with a recent version of pip will install a pre-3.0 version of h5py. However, pre-3.0 versions of h5py do not have Python 3.9 wheels available on PyPI, and so the package must be built from source for Python 3.9, which requires an hdf5 library to be installed. This PR installs such a library for Ubuntu and macOS when testing Python 3.9; testing Python 3.9 on Windows is disabled for now as installing hdf5 on that OS is apparently quite involved.