Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround: prevent upload of files larger than 67108864000 #303

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Dec 3, 2020

See dandi/dandiarchive-legacy#517 for more information

If looks kosher and doesn't break anything, we should get it into the masses, unless we find a proper solution to that issue.

we might want to announce all prior versions of dandi-cli as "bad" in .et

@yarikoptic yarikoptic added bug Something isn't working release Create a release when this pr is merged labels Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #303 (66af6ce) into master (511143d) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   81.88%   81.79%   -0.10%     
==========================================
  Files          54       54              
  Lines        4886     4889       +3     
==========================================
- Hits         4001     3999       -2     
- Misses        885      890       +5     
Flag Coverage Δ
unittests 81.79% <66.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/upload.py 71.08% <66.66%> (-0.06%) ⬇️
dandi/cli/cmd_organize.py 77.30% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511143d...66af6ce. Read the comment docs.

@satra
Copy link
Member

satra commented Dec 3, 2020

i think we should fix the issue because we will be getting TB size files from the U01 project.

@satra
Copy link
Member

satra commented Dec 3, 2020

we can do a quick fix to limit it, but we should fix it urgently.

@yarikoptic
Copy link
Member Author

I know that it should be fixed urgently... but we also should prevent data loss on uploads which might happen meanwhile, and may be fix isn't trivial. I will wait until the end of the day and then proceed/merge.

@yarikoptic yarikoptic merged commit d73f21a into master Dec 4, 2020
@yarikoptic yarikoptic deleted the workaround-size branch December 4, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants