Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make most things optional #234

Merged
merged 1 commit into from
Sep 9, 2020
Merged

make most things optional #234

merged 1 commit into from
Sep 9, 2020

Conversation

satra
Copy link
Member

@satra satra commented Sep 9, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #234 into nwb2asset will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           nwb2asset     #234      +/-   ##
=============================================
- Coverage      82.29%   82.03%   -0.26%     
=============================================
  Files             51       51              
  Lines           4333     4276      -57     
=============================================
- Hits            3566     3508      -58     
- Misses           767      768       +1     
Flag Coverage Δ
#unittests 82.03% <100.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/models.py 81.10% <100.00%> (ø)
dandi/tests/fixtures.py 95.91% <0.00%> (-2.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6811bc9...560e224. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I will leave honors to @jwodder to merge

@jwodder jwodder merged commit ec32419 into dandi:nwb2asset Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants