Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure flake8 to run on test code as well #187

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 11, 2020

There have been several times today and/or yesterday when linting of test files would have saved me some failed trips through the test suite.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #187 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   76.56%   76.56%   -0.01%     
==========================================
  Files          41       41              
  Lines        3124     3123       -1     
==========================================
- Hits         2392     2391       -1     
  Misses        732      732              
Flag Coverage Δ
#unittests 76.56% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/support/tests/test_digests.py 100.00% <ø> (ø)
dandi/tests/fixtures.py 97.36% <ø> (ø)
dandi/tests/skip.py 88.88% <ø> (ø)
dandi/tests/test_download.py 100.00% <ø> (ø)
dandi/tests/test_utils.py 100.00% <ø> (ø)
dandi/conftest.py 100.00% <100.00%> (ø)
dandi/support/tests/test_cache.py 93.00% <100.00%> (ø)
dandi/tests/test_organize.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92474c7...fafd5ad. Read the comment docs.

@yarikoptic yarikoptic merged commit 14b17b3 into master Aug 11, 2020
@yarikoptic yarikoptic deleted the flake8-tests branch August 11, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants