Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xfail marks for some tests: test_nwb2asset_remote_asset, test_reextract_metadata, test_IteratorWithAggregation #1512

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add xfail marks for some tests: test_nwb2asset_remote_asset, test_reextract_metadata, test_IteratorWithAggregation #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55cd3f9
xfail test_IteratorWithAggregation on Windows
yarikoptic Sep 27, 2024
d06e450
TST: xfail test_reextract_metadata on NFS CI setup
yarikoptic Sep 27, 2024
01980d5
XFAIL timing out test test_nwb2asset_remote_asset
yarikoptic Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dandi/cli/tests/test_service_scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
DATA_DIR = Path(__file__).with_name("data")


@pytest.mark.xfail(
"nfsmount" in os.environ.get("TMPDIR", ""),
reason="https://github.com/dandi/dandi-cli/issues/1507",
)
def test_reextract_metadata(
monkeypatch: pytest.MonkeyPatch, nwb_dandiset: SampleDandiset
) -> None:
Expand Down
3 changes: 3 additions & 0 deletions dandi/support/tests/test_iterators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import pytest

from dandi.utils import on_windows

from ..iterators import IteratorWithAggregation


Expand Down Expand Up @@ -31,6 +33,7 @@ def sleeping_range(n, secs=0.01, thr=None):
raise ValueError(i)


@pytest.mark.xfail(on_windows, reason="https://github.com/dandi/dandi-cli/issues/1510")
def test_IteratorWithAggregation():
def sumup(v, t=0):
return v + t
Expand Down
1 change: 1 addition & 0 deletions dandi/tests/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ def test_nwb2asset(simple2_nwb: Path) -> None:
)


@pytest.mark.xfail(reason="https://github.com/dandi/dandi-cli/issues/1450")
def test_nwb2asset_remote_asset(nwb_dandiset: SampleDandiset) -> None:
pytest.importorskip("fsspec")
asset = nwb_dandiset.dandiset.get_asset_by_path("sub-mouse001/sub-mouse001.nwb")
Expand Down
Loading