Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to python 3.9 in dev-deps CI matrix run since dev deps are now beginning to drop Python 3.8 which is EOL soon #1506

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Sep 27, 2024

Fixes #1503

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (d5c4a3f) to head (faff2f6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   88.56%   88.63%   +0.07%     
==========================================
  Files          77       77              
  Lines       10572    10572              
==========================================
+ Hits         9363     9371       +8     
+ Misses       1209     1201       -8     
Flag Coverage Δ
unittests 88.63% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic changed the title Dev deps are now beginning to drop Python 3.8 which is EOL soon Switch to python 3.9 in dev-deps CI matrix run since dev deps are now beginning to drop Python 3.8 which is EOL soon Sep 27, 2024
@yarikoptic yarikoptic added the tests Add or improve existing tests label Sep 27, 2024
@yarikoptic
Copy link
Member

added a label for auto , and adjusted PR title so it is descriptive of the change whenever it gets into CHANGELOG. dev-deps is green, let's proceed

@yarikoptic yarikoptic merged commit af2bae5 into dandi:master Sep 27, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 tests failing
2 participants