Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "cache_spec:False" in our copy_nwb_file helper while exporting NWB copy #1497

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

yarikoptic
Copy link
Member

  • Stopped since ideally we should make it dependent on either original file contains the spec. Question posted

…B copy

Stopped since ideally we should make it dependent on either original
file contains the spec
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (44e097f) to head (8dba010).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
- Coverage   88.55%   88.55%   -0.01%     
==========================================
  Files          77       77              
  Lines       10568    10575       +7     
==========================================
+ Hits         9359     9365       +6     
- Misses       1209     1210       +1     
Flag Coverage Δ
unittests 88.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandi/pynwb_utils.py Outdated Show resolved Hide resolved
@yarikoptic yarikoptic marked this pull request as ready for review September 13, 2024 14:56
@yarikoptic yarikoptic requested a review from rly September 13, 2024 14:56
@yarikoptic yarikoptic added the internal Changes only affect the internal API label Sep 27, 2024
@yarikoptic
Copy link
Member Author

filed

@yarikoptic yarikoptic merged commit fdd65d0 into master Sep 27, 2024
24 of 28 checks passed
@yarikoptic yarikoptic deleted the enh-test-export branch September 27, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants