Clean up URL parsing in extract_species()
#1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
added
internal
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
+ Coverage 88.53% 88.61% +0.07%
==========================================
Files 77 77
Lines 10527 10528 +1
==========================================
+ Hits 9320 9329 +9
+ Misses 1207 1199 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
since otherwise while looking at the use not clear
what that index is. May be later it would be even
some other level (but still the same template) than species
so best to just mention that it is NCBITAXON URL
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi SPECIES_URI_TEMPLATE NCBITAXON_URI_TEMPLATE",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
reviewed
Mar 1, 2024
| @@ -329,66 +329,68 @@ def extract_cellLine(metadata: dict) -> str | None: | |||
| return None | |||
|
|
|||
|
|
|||
| NCBITAXON_URI_TEMPLATE = "http://purl.obolibrary.org/obo/NCBITaxon_{}" | |||
There was a problem hiding this comment.
pushed a renaming for that template variable. If really don't like it -- revert, but I think that it is better when more specific like this
yarikoptic
approved these changes
Mar 1, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarl doesn't really seem like it would help with this bit, but I came up with a different way to make the code arguably cleaner.