Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check file sizes before & after uploading #1374

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Double-check file sizes before & after uploading #1374

merged 3 commits into from
Dec 13, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Dec 11, 2023

Closes #1373.

@jwodder jwodder added the patch Increment the patch version when merged label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a51e0a7) 88.44% compared to head (cec2e23) 88.54%.
Report is 4 commits behind head on master.

Files Patch % Lines
dandi/files/bases.py 87.17% 5 Missing ⚠️
dandi/files/zarr.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   88.44%   88.54%   +0.10%     
==========================================
  Files          77       77              
  Lines       10463    10511      +48     
==========================================
+ Hits         9254     9307      +53     
+ Misses       1209     1204       -5     
Flag Coverage Δ
unittests 88.54% <89.47%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandi/utils.py Outdated Show resolved Hide resolved
@yarikoptic yarikoptic merged commit 7b906e6 into master Dec 13, 2023
28 checks passed
@yarikoptic yarikoptic deleted the gh-1373 branch December 13, 2023 20:09
Copy link

github-actions bot commented Jan 9, 2024

🚀 PR was released in 0.59.0 🚀

@jwodder jwodder added the HIFNI Zarr uploads failing with "A header you provided implies functionality that is not implemented" label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HIFNI Zarr uploads failing with "A header you provided implies functionality that is not implemented" patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make file upload be robust to file size changes
2 participants