Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize spaces and ,s in organized filenames #1351

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

yarikoptic
Copy link
Member

black for some reason introduced some changes, I didn't fight.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c567c8b) 89.04% compared to head (8d7b1a6) 89.05%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   89.04%   89.05%           
=======================================
  Files          76       75    -1     
  Lines       10243    10286   +43     
=======================================
+ Hits         9121     9160   +39     
- Misses       1122     1126    +4     
Flag Coverage Δ
unittests 89.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandi/organize.py 85.26% <100.00%> (-0.04%) ⬇️
dandi/tests/test_organize.py 95.58% <100.00%> (+0.04%) ⬆️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit dcf05a6 into master Nov 9, 2023
25 checks passed
@yarikoptic yarikoptic deleted the bf-sanitize-spaces branch November 9, 2023 16:36
Copy link

🚀 PR was released in 0.58.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants