Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing errors due to keyring and cv externals changes. #1316

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 9, 2023

No description provided.

@yarikoptic
Copy link
Member

is that due to changes in types in those involved (keyring, cv?) libraries i.e. could fail if used with older libs?

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (71bd0fe) 88.82% compared to head (5a10ab9) 88.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
- Coverage   88.82%   88.81%   -0.01%     
==========================================
  Files          76       76              
  Lines       10191    10192       +1     
==========================================
  Hits         9052     9052              
- Misses       1139     1140       +1     
Flag Coverage Δ
unittests 88.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dandi/tests/fixtures.py 97.52% <ø> (ø)
dandi/keyring.py 88.88% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder
Copy link
Member Author

jwodder commented Aug 9, 2023

@yarikoptic

  • The keyring-related typing errors were due to changes in mypy and/or keyring (I'm not going to try to figure out which). I don't believe keyring changed in any way that affects the functioning of dandi.
  • I believe the cv2 typing errors occurred because the library (which is written in C++) only recently added Python type annotations, and these annotations describe interfaces that are stricter than what actually works (e.g., apiPreference is declared as an int, but the tests still succeed when a None is passed instead). This PR updates the code to use cv2 the way its annotations say it should be used.

@yarikoptic
Copy link
Member

coolio, I will then merge this one whenever turns green and then #1315 to release. Thank you!

@yarikoptic yarikoptic changed the title Fix typing errors Fix typing errors due to keyring and cv externals changes. Aug 9, 2023
@yarikoptic yarikoptic merged commit 4d5b46b into master Aug 10, 2023
23 of 24 checks passed
@yarikoptic yarikoptic deleted the fix-typing branch August 10, 2023 14:09
@github-actions
Copy link

🚀 PR was released in 0.56.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants