Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C elegans #1276

Merged
merged 4 commits into from
Apr 17, 2023
Merged

C elegans #1276

merged 4 commits into from
Apr 17, 2023

Conversation

bendichter
Copy link
Member

Add support for C. elegans

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (cfb39be) 89.00% compared to head (30da484) 88.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
- Coverage   89.00%   88.97%   -0.03%     
==========================================
  Files          76       76              
  Lines        9793     9804      +11     
==========================================
+ Hits         8716     8723       +7     
- Misses       1077     1081       +4     
Flag Coverage Δ
unittests 88.97% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/metadata.py 89.70% <ø> (ø)
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dysprague
Copy link

I am working on an extension to support optophysiology experiments in C Elegans. The extension seems to be working well and I am hoping to upload datasets to DANDI very soon, so it would be very helpful for DANDI to have support for C Elegans species quickly. This is an effort to help facilitate data sharing across a few labs, so I know this change would be helpful to a lot of people in the worm community.

@@ -526,6 +526,12 @@ def extract_cellLine(metadata: dict) -> Optional[str]:
"http://purl.obolibrary.org/obo/NCBITaxon_7955",
"Danio rerio - Zebra fish",
),
(
["c. elegans", "Caenorhabditis elegans"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the first one with a capital letter in alternative names.

Looking at https://github.com/dandi/dandi-cli/blob/HEAD/dandi/metadata.py#L598 we need

Suggested change
["c. elegans", "Caenorhabditis elegans"],
["c. elegans", "caenorhabditis elegans"],

But also I think we better also add .lower() there to key (this value) to altogether ignore case , will do both now for this PR.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, if no surprises from CI - let's merge

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Apr 17, 2023
@bendichter bendichter merged commit c23c4ce into master Apr 17, 2023
@bendichter bendichter deleted the c_elegans branch April 17, 2023 20:20
@github-actions
Copy link

🚀 PR was released in 0.54.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants