Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Other sex as o abbreviation #1275

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Accept Other sex as o abbreviation #1275

merged 2 commits into from
Apr 12, 2023

Conversation

bendichter
Copy link
Member

Add the ability for Subject.sex to be "O", indicating "Other" sex.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +25.87 🎉

Comparison is base (3fa41e7) 63.05% compared to head (eabcfff) 88.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1275       +/-   ##
===========================================
+ Coverage   63.05%   88.93%   +25.87%     
===========================================
  Files          76       76               
  Lines        9698     9793       +95     
===========================================
+ Hits         6115     8709     +2594     
+ Misses       3583     1084     -2499     
Flag Coverage Δ
unittests 88.93% <100.00%> (+25.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/metadata.py 89.70% <100.00%> (+1.17%) ⬆️

... and 35 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dysprague
Copy link

I am working on an extension to support optophysiology experiments in C Elegans. C elegans have two sexes, male (XO) and hermaphrodite (XX). It would be very helpful to be able to use the 'other' categorization for this.

@yarikoptic yarikoptic changed the title Other sex Accept Other sex as o abbreviation Apr 12, 2023
@yarikoptic
Copy link
Member

Adjusted the title since Other actually seems was supported already.

@yarikoptic yarikoptic merged commit 5a33118 into master Apr 12, 2023
@yarikoptic yarikoptic deleted the other_sex branch April 12, 2023 03:40
@github-actions
Copy link

🚀 PR was released in 0.53.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants