Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log more information about retried HTTP requests #1264

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 4, 2023

ref: #1257

@jwodder jwodder added the patch Increment the patch version when merged label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.10 ⚠️

Comparison is base (84ed322) 89.09% compared to head (522c5ec) 88.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
- Coverage   89.09%   88.99%   -0.10%     
==========================================
  Files          76       76              
  Lines        9750     9753       +3     
==========================================
- Hits         8687     8680       -7     
- Misses       1063     1073      +10     
Flag Coverage Δ
unittests 88.99% <42.85%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_dandiapi.py 100.00% <ø> (ø)
dandi/dandiapi.py 86.51% <33.33%> (-0.24%) ⬇️
dandi/consts.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Apr 5, 2023
@yarikoptic
Copy link
Member

Ok, let's log more details and see if any come handy.

@yarikoptic yarikoptic merged commit af5eaa0 into master Apr 5, 2023
@yarikoptic yarikoptic deleted the more-retry-logs branch April 5, 2023 00:38
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

🚀 PR was released in 0.52.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants