Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pathlib more in tests #1233

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Use pathlib more in tests #1233

merged 1 commit into from
Mar 1, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 1, 2023

No description provided.

@jwodder jwodder added the internal Changes only affect the internal API label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 96.46% and project coverage change: -0.04 ⚠️

Comparison is base (1818b2f) 89.18% compared to head (83e2953) 89.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   89.18%   89.15%   -0.04%     
==========================================
  Files          74       74              
  Lines        9571     9570       -1     
==========================================
- Hits         8536     8532       -4     
- Misses       1035     1038       +3     
Flag Coverage Δ
unittests 89.15% <96.46%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/validate.py 97.61% <ø> (ø)
dandi/tests/test_validate.py 81.81% <85.00%> (-1.17%) ⬇️
dandi/tests/fixtures.py 97.33% <94.73%> (-0.01%) ⬇️
dandi/cli/tests/test_cmd_ls.py 100.00% <100.00%> (ø)
dandi/cli/tests/test_cmd_validate.py 100.00% <100.00%> (ø)
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)
dandi/tests/test_download.py 100.00% <100.00%> (ø)
dandi/tests/test_files.py 100.00% <100.00%> (ø)
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)
dandi/tests/test_organize.py 95.34% <100.00%> (-0.08%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Great, thank you!

@yarikoptic yarikoptic merged commit 56646ec into master Mar 1, 2023
@yarikoptic yarikoptic deleted the morepath branch March 1, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants