Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporarily disable all tests which talk to obolibrary" - ontobee said to be back #1226

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

yarikoptic
Copy link
Member

We scared it well enough that it returned immediately after ;)

This reverts commit 446cf7b.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Feb 25, 2023
@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 88.85% // Head: 89.16% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (5823aef) compared to base (9b6dea6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
+ Coverage   88.85%   89.16%   +0.30%     
==========================================
  Files          74       74              
  Lines        9443     9443              
==========================================
+ Hits         8391     8420      +29     
+ Misses       1052     1023      -29     
Flag Coverage Δ
unittests 89.16% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_metadata.py 100.00% <0.00%> (+2.80%) ⬆️
dandi/metadata.py 87.94% <0.00%> (+6.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic merged commit a7af085 into master Feb 25, 2023
@yarikoptic yarikoptic deleted the bf-obolibrary branch February 25, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant