Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors; unbound mypy #1207

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix type errors; unbound mypy #1207

merged 1 commit into from
Feb 7, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 7, 2023

This silences some typing errors related in some inscrutable way to the latest version of retrying. It also unrestricts the maximum mypy version so that we can use the newly-released v1.0.

@jwodder jwodder added the tests Add or improve existing tests label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 89.16% // Head: 89.16% // No change to project coverage 👍

Coverage data is based on head (9095ddc) compared to base (67f015c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1207   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          76       76           
  Lines        9468     9468           
=======================================
  Hits         8442     8442           
  Misses       1026     1026           
Flag Coverage Δ
unittests 89.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/metadata.py 87.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit 4341976 into master Feb 7, 2023
@yarikoptic yarikoptic deleted the fix-typing branch February 7, 2023 20:32
@github-actions
Copy link

🚀 PR was released in 0.49.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants