Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging bids_validate into validate, stop validating nested BIDS. #1203

Merged
merged 47 commits into from
Mar 1, 2023
Merged

Merging bids_validate into validate, stop validating nested BIDS. #1203

merged 47 commits into from
Mar 1, 2023
+119 −81

Commits on Feb 25, 2023

  1. Fixing preexisting typo

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5b76ced View commit details
    Browse the repository at this point in the history

  2. Added reference test for NWB validation

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    61bdb3c View commit details
    Browse the repository at this point in the history

  3. BIDS initialization support for automatic file finding

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    96bf6b7 View commit details
    Browse the repository at this point in the history

  4. Type fix

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    b29db3e View commit details
    Browse the repository at this point in the history

  5. Typing fix...

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    33eeda9 View commit details
    Browse the repository at this point in the history

  6. Added single-file test for new merged validation function

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    04623f7 View commit details
    Browse the repository at this point in the history

  7. Deprecating report parameter

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0e60906 View commit details
    Browse the repository at this point in the history

  8. Removed debugging code

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    28ce4c6 View commit details
    Browse the repository at this point in the history

  9. Turning example BIDS datasets into “real” Dandisets

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    782a5fb View commit details
    Browse the repository at this point in the history

  10. Once-off DANDIfication of BIDS testdataset no longer required

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    9231ceb View commit details
    Browse the repository at this point in the history

  11. Workaround for iterative validation

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    04db801 View commit details
    Browse the repository at this point in the history

  12. Additional assertion and comments in test

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d87a77a View commit details
    Browse the repository at this point in the history

  13. Type fix and expanded comment

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    85f452c View commit details
    Browse the repository at this point in the history

  14. Always running BIDS validation on the BIDS root.

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    45209e2 View commit details
    Browse the repository at this point in the history

  15. Removed debugging print call

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6533e01 View commit details
    Browse the repository at this point in the history

  16. Typo

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d3fb89d View commit details
    Browse the repository at this point in the history

  17. Better approach to asset creation, not supporting nested BIDS

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e51db24 View commit details
    Browse the repository at this point in the history

  18. Further merging of bids validation instances into vanilla validate

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    674adb7 View commit details
    Browse the repository at this point in the history

  19. Deprecating dandi validate_bids

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    cee83fe View commit details
    Browse the repository at this point in the history

  20. Reworked logic to avoid nesting

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    778848f View commit details
    Browse the repository at this point in the history

  21. removed superfluous list bracket from condition test 

    Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
    @TheChymera @jwodder
    TheChymera and jwodder committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    7731474 View commit details
    Browse the repository at this point in the history

  22. no need for os.path.join in pathlib constructor 

    Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
    @TheChymera @jwodder
    TheChymera and jwodder committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6c5f6a4 View commit details
    Browse the repository at this point in the history

  23. Removed traces of validate_bids and fixed generator object handling

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    87c0b9f View commit details
    Browse the repository at this point in the history

  24. Added reference test for NWB validation

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    9050cd2 View commit details
    Browse the repository at this point in the history

  25. BIDS initialization support for automatic file finding

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0520bb4 View commit details
    Browse the repository at this point in the history

  26. Type fix

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    82ca625 View commit details
    Browse the repository at this point in the history

  27. Typing fix...

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    b854794 View commit details
    Browse the repository at this point in the history

  28. Added single-file test for new merged validation function

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    eef62b2 View commit details
    Browse the repository at this point in the history

  29. Deprecating report parameter

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    701f827 View commit details
    Browse the repository at this point in the history

  30. Removed debugging code

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6632c4e View commit details
    Browse the repository at this point in the history

  31. Once-off DANDIfication of BIDS testdataset no longer required

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f8997bd View commit details
    Browse the repository at this point in the history

  32. Workaround for iterative validation

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    fea1b37 View commit details
    Browse the repository at this point in the history

  33. Additional assertion and comments in test

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e182970 View commit details
    Browse the repository at this point in the history

  34. Type fix and expanded comment

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    039843b View commit details
    Browse the repository at this point in the history

  35. Removed debugging print call

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    62d3a7c View commit details
    Browse the repository at this point in the history

  36. Better approach to asset creation, not supporting nested BIDS

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    930b1dc View commit details
    Browse the repository at this point in the history

  37. Further merging of bids validation instances into vanilla validate

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    7997835 View commit details
    Browse the repository at this point in the history

  38. Reworked logic to avoid nesting

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    4ccdcc3 View commit details
    Browse the repository at this point in the history

  39. removed superfluous list bracket from condition test 

    Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
    @TheChymera @jwodder
    TheChymera and jwodder committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d7923c2 View commit details
    Browse the repository at this point in the history

  40. no need for os.path.join in pathlib constructor 

    Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
    @TheChymera @jwodder
    TheChymera and jwodder committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0d291ed View commit details
    Browse the repository at this point in the history

  41. Treat dataset_description.json files below other DD.J files as generi… 

    …c assets that don't start new BIDS datasets
    @jwodder @TheChymera
    jwodder authored and TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f879563 View commit details
    Browse the repository at this point in the history

  42. Deprecated parameter

    @TheChymera
    TheChymera committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    3ebf99f View commit details
    Browse the repository at this point in the history

  43. Code style and documentation fixes as per yoh review 

    Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
    @TheChymera @yarikoptic
    TheChymera and yarikoptic committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5eae970 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Parameterized subdirectory dandification

    @TheChymera
    TheChymera committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    727a093 View commit details
    Browse the repository at this point in the history

  2. Bringing back function to set-up alias and provide deprecation warning

    @TheChymera
    TheChymera committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    dc3b720 View commit details
    Browse the repository at this point in the history

  3. No longer writing report log for BIDS validationo

    @TheChymera
    TheChymera committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c824ee7 View commit details
    Browse the repository at this point in the history

  4. Invoking click command, making DeprecationWarning visible

    @TheChymera
    TheChymera committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    b4e451f View commit details
    Browse the repository at this point in the history