Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected reporting function logic to complete group message variable #1166

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

TheChymera
Copy link
Contributor

Addressing issue raised here: #1165 (comment)

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 88.27% // Head: 88.25% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (d2d6836) compared to base (0439caf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   88.27%   88.25%   -0.03%     
==========================================
  Files          73       73              
  Lines        8817     8818       +1     
==========================================
- Hits         7783     7782       -1     
- Misses       1034     1036       +2     
Flag Coverage Δ
unittests 88.25% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_validate.py 73.03% <0.00%> (-0.83%) ⬇️
dandi/support/threaded_walk.py 93.10% <0.00%> (-1.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

@TheChymera as PR title would be changelog entry -- please expand it slightly to become self-descriptive. Otherwise not clear what logic was fixed and why/for what reason. And btw -- for our own sake, what it resulted in really fixed, e.g. can you show on example output in master version vs this PR fixed one?

with the appropriate error message if there is only one, and a period if
not.
@TheChymera TheChymera changed the title Fixed typos and corrected logic Corrected reporting function logic to complete group message variable Nov 29, 2022
@TheChymera
Copy link
Contributor Author

@yarikoptic edited.

@jwodder jwodder added the patch Increment the patch version when merged label Nov 29, 2022
@yarikoptic yarikoptic merged commit 0ad1346 into master Nov 29, 2022
@yarikoptic yarikoptic deleted the reporting branch November 29, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants