-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DANDI_TESTS_PULL_DOCKER_COMPOSE
envvar
#1141
Conversation
Codecov ReportBase: 87.93% // Head: 62.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
===========================================
- Coverage 87.93% 62.78% -25.15%
===========================================
Files 73 73
Lines 8585 8586 +1
===========================================
- Hits 7549 5391 -2158
- Misses 1036 3195 +2159
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Do we need a release to take advantage of this in dandi-archive testing? if so -- please add release
label and merge
answering my own question since was looking at that workflow anyways -- we do want release since we test against both dev and release, thus adding the label |
@yarikoptic Dandi Archive tests against both the latest release of dandi-cli and against the master branch, so a release isn't really needed. |
;-) indeed the fact that we test against both could be treated the other way as well (that no release is needed). But I think we better re-establish the common base now, so I will keep the |
hm, testing is failing but likely due to the dandi-archive introducing breaking change and this PR trying to allow to avoid that in the future. I do not see how this could add breakage, so will merge |
🚀 PR was released in |
Closes #1140.