Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase number of trials in docker_compose_setup to 25 #1122

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

djarecka
Copy link
Member

@djarecka djarecka commented Oct 3, 2022

increasing number of trials to connect to dandisets in docker_compose_setup

@jwodder @yarikoptic - closing my tabs, restarting laptop, updating docker didn't help, still was timing out...

@yarikoptic yarikoptic changed the title increasing number of trials in docker_compose_setup increase number of trials in docker_compose_setup to 25 Oct 3, 2022
@yarikoptic yarikoptic added the tests Add or improve existing tests label Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 88.57% // Head: 87.90% // Decreases project coverage by -0.66% ⚠️

Coverage data is based on head (bf39a14) compared to base (d5ed594).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   88.57%   87.90%   -0.67%     
==========================================
  Files          76       73       -3     
  Lines        9117     8549     -568     
==========================================
- Hits         8075     7515     -560     
+ Misses       1042     1034       -8     
Flag Coverage Δ
unittests 87.90% <100.00%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 98.07% <100.00%> (+<0.01%) ⬆️
dandi/support/threaded_walk.py 92.85% <0.00%> (-1.79%) ⬇️
dandi/organize.py 82.81% <0.00%> (-0.45%) ⬇️
dandi/tests/test_download.py
dandi/__init__.py
dandi/tests/test_move.py
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic merged commit e021829 into dandi:master Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🚀 PR was released in 0.46.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants