Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_content_url(): If a HEAD fails, return the failing URL #1107

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 22, 2022

Closes #980.

@jwodder jwodder added patch Increment the patch version when merged Python API labels Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1107 (f5a6693) into master (647b351) will increase coverage by 0.07%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
+ Coverage   88.82%   88.89%   +0.07%     
==========================================
  Files          78       78              
  Lines        9504     9512       +8     
==========================================
+ Hits         8442     8456      +14     
+ Misses       1062     1056       -6     
Flag Coverage Δ
unittests 88.89% <93.75%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 88.07% <90.90%> (+0.17%) ⬆️
dandi/tests/test_dandiapi.py 98.44% <100.00%> (+0.01%) ⬆️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yarikoptic
Copy link
Member

Great, thanks!

@yarikoptic yarikoptic merged commit 99fa604 into master Aug 24, 2022
@yarikoptic yarikoptic deleted the gh-980 branch August 24, 2022 14:33
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

🚀 PR was released in 0.46.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged Python API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_content_url(follow_redirects=True) should stop when reaching a "folder"
2 participants