-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured validation results #1104
Commits on Oct 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 696e7fe - Browse repository at this point
Copy the full SHA 696e7feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 037dc5e - Browse repository at this point
Copy the full SHA 037dc5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bc01ba - Browse repository at this point
Copy the full SHA 3bc01baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43ab1f5 - Browse repository at this point
Copy the full SHA 43ab1f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f88e4e - Browse repository at this point
Copy the full SHA 1f88e4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e8e4b7 - Browse repository at this point
Copy the full SHA 8e8e4b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8561215 - Browse repository at this point
Copy the full SHA 8561215View commit details -
Configuration menu - View commit details
-
Copy full SHA for f082382 - Browse repository at this point
Copy the full SHA f082382View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd77af2 - Browse repository at this point
Copy the full SHA dd77af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for aefb337 - Browse repository at this point
Copy the full SHA aefb337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c8ddd3 - Browse repository at this point
Copy the full SHA 1c8ddd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6d494 - Browse repository at this point
Copy the full SHA cb6d494View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2b21ed - Browse repository at this point
Copy the full SHA e2b21edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af720a - Browse repository at this point
Copy the full SHA 8af720aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea4e790 - Browse repository at this point
Copy the full SHA ea4e790View commit details -
Configuration menu - View commit details
-
Copy full SHA for db175a2 - Browse repository at this point
Copy the full SHA db175a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a90c99a - Browse repository at this point
Copy the full SHA a90c99aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3304b45 - Browse repository at this point
Copy the full SHA 3304b45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a9377e - Browse repository at this point
Copy the full SHA 2a9377eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a0875b - Browse repository at this point
Copy the full SHA 6a0875bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f248b9 - Browse repository at this point
Copy the full SHA 4f248b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a564d0d - Browse repository at this point
Copy the full SHA a564d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc57bfc - Browse repository at this point
Copy the full SHA cc57bfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15e1cfb - Browse repository at this point
Copy the full SHA 15e1cfbView commit details -
Use assert to ensure that Optional becomes non-optional for type chec…
…king also used more descriptive "result" variable instead of "i". We contemplated some other name (like vrs - for "validation results") but it was not liked
Configuration menu - View commit details
-
Copy full SHA for 89a070a - Browse repository at this point
Copy the full SHA 89a070aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe238b6 - Browse repository at this point
Copy the full SHA fe238b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25194ee - Browse repository at this point
Copy the full SHA 25194eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e630fb8 - Browse repository at this point
Copy the full SHA e630fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72f47a0 - Browse repository at this point
Copy the full SHA 72f47a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b51e92e - Browse repository at this point
Copy the full SHA b51e92eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94a1793 - Browse repository at this point
Copy the full SHA 94a1793View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec59dad - Browse repository at this point
Copy the full SHA ec59dadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e17e9 - Browse repository at this point
Copy the full SHA 43e17e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f2e4ae - Browse repository at this point
Copy the full SHA 4f2e4aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf5c0f1 - Browse repository at this point
Copy the full SHA bf5c0f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 697b24d - Browse repository at this point
Copy the full SHA 697b24dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb52d56 - Browse repository at this point
Copy the full SHA bb52d56View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee9492a - Browse repository at this point
Copy the full SHA ee9492aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c828628 - Browse repository at this point
Copy the full SHA c828628View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f1c6a7 - Browse repository at this point
Copy the full SHA 2f1c6a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 155e557 - Browse repository at this point
Copy the full SHA 155e557View commit details -
Configuration menu - View commit details
-
Copy full SHA for f30ad99 - Browse repository at this point
Copy the full SHA f30ad99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 676cbc3 - Browse repository at this point
Copy the full SHA 676cbc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a8861b - Browse repository at this point
Copy the full SHA 9a8861bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74cc797 - Browse repository at this point
Copy the full SHA 74cc797View commit details -
Configuration menu - View commit details
-
Copy full SHA for db6a81f - Browse repository at this point
Copy the full SHA db6a81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 715f70e - Browse repository at this point
Copy the full SHA 715f70eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb5847c - Browse repository at this point
Copy the full SHA fb5847cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0027c3 - Browse repository at this point
Copy the full SHA e0027c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 453cd65 - Browse repository at this point
Copy the full SHA 453cd65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 786729a - Browse repository at this point
Copy the full SHA 786729aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0070bd - Browse repository at this point
Copy the full SHA d0070bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b205aaf - Browse repository at this point
Copy the full SHA b205aafView commit details -
Configuration menu - View commit details
-
Copy full SHA for d04f4bd - Browse repository at this point
Copy the full SHA d04f4bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d21f4e - Browse repository at this point
Copy the full SHA 7d21f4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba4b7b - Browse repository at this point
Copy the full SHA 4ba4b7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e54be - Browse repository at this point
Copy the full SHA 23e54beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28e7374 - Browse repository at this point
Copy the full SHA 28e7374View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3702eac - Browse repository at this point
Copy the full SHA 3702eacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9723c - Browse repository at this point
Copy the full SHA 2d9723cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61e5d3a - Browse repository at this point
Copy the full SHA 61e5d3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1711354 - Browse repository at this point
Copy the full SHA 1711354View commit details -
Configuration menu - View commit details
-
Copy full SHA for 122581a - Browse repository at this point
Copy the full SHA 122581aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e25375b - Browse repository at this point
Copy the full SHA e25375bView commit details -
Unified error reporting across validation types
also removed part of error reporting which was reporting valid files, let me know if you need it back.
Configuration menu - View commit details
-
Copy full SHA for e292718 - Browse repository at this point
Copy the full SHA e292718View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4a36ca - Browse repository at this point
Copy the full SHA c4a36caView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf34de3 - Browse repository at this point
Copy the full SHA cf34de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e363670 - Browse repository at this point
Copy the full SHA e363670View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a56acd - Browse repository at this point
Copy the full SHA 6a56acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4ad1bc - Browse repository at this point
Copy the full SHA b4ad1bcView commit details -
RF+BF: address circular import, unify more of validations into Valida…
…tionResults TODO: pretty much go through all other instances were "str" is returned for an error. Most of them could be caught up via `tox -e typing` or just inspecting other code paths. We also raised following concerns/topics for possible future development - do not return error structs for exception handling where we catch errors from opening files etc. But may be there was a reason why we decided to work with it this way instead of just handling exceptions. - there is .location (within .nwb / hdf5 file) to point more specifically within nwb file internal structure. We need to provide location for that in our data structure. But as we have asset_paths, we might want to do that as a dict.
Configuration menu - View commit details
-
Copy full SHA for de27873 - Browse repository at this point
Copy the full SHA de27873View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b7e680 - Browse repository at this point
Copy the full SHA 6b7e680View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccf9491 - Browse repository at this point
Copy the full SHA ccf9491View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3106f4 - Browse repository at this point
Copy the full SHA b3106f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49c9a0a - Browse repository at this point
Copy the full SHA 49c9a0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9861be1 - Browse repository at this point
Copy the full SHA 9861be1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f387998 - Browse repository at this point
Copy the full SHA f387998View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04ee73c - Browse repository at this point
Copy the full SHA 04ee73cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d161b46 - Browse repository at this point
Copy the full SHA d161b46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 482246a - Browse repository at this point
Copy the full SHA 482246aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1691547 - Browse repository at this point
Copy the full SHA 1691547View commit details -
Configuration menu - View commit details
-
Copy full SHA for 889d2e7 - Browse repository at this point
Copy the full SHA 889d2e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd03eb5 - Browse repository at this point
Copy the full SHA dd03eb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2f4c2e - Browse repository at this point
Copy the full SHA b2f4c2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d77a0d - Browse repository at this point
Copy the full SHA 0d77a0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e263bf4 - Browse repository at this point
Copy the full SHA e263bf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b58dce - Browse repository at this point
Copy the full SHA 8b58dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f577d - Browse repository at this point
Copy the full SHA f2f577dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c1890c - Browse repository at this point
Copy the full SHA 5c1890cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e30809d - Browse repository at this point
Copy the full SHA e30809dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87048c7 - Browse repository at this point
Copy the full SHA 87048c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b35b4 - Browse repository at this point
Copy the full SHA d4b35b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for acd78b7 - Browse repository at this point
Copy the full SHA acd78b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2ad26 - Browse repository at this point
Copy the full SHA cc2ad26View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5e16b1 - Browse repository at this point
Copy the full SHA b5e16b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f49cc9 - Browse repository at this point
Copy the full SHA 9f49cc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 382c3ae - Browse repository at this point
Copy the full SHA 382c3aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d71483 - Browse repository at this point
Copy the full SHA 8d71483View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d4e284 - Browse repository at this point
Copy the full SHA 2d4e284View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c8d034 - Browse repository at this point
Copy the full SHA 2c8d034View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80db60e - Browse repository at this point
Copy the full SHA 80db60eView commit details -
Configuration menu - View commit details
-
Copy full SHA for af48872 - Browse repository at this point
Copy the full SHA af48872View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15ce3c7 - Browse repository at this point
Copy the full SHA 15ce3c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c430f6 - Browse repository at this point
Copy the full SHA 8c430f6View commit details -
Standardized CLI NWB validator wrt BIDS validator draft and added tests
Still using 2 separate functions, merging of validation functions best for subsequent PR
Configuration menu - View commit details
-
Copy full SHA for 6348f64 - Browse repository at this point
Copy the full SHA 6348f64View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed5f353 - Browse repository at this point
Copy the full SHA ed5f353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65ae2c9 - Browse repository at this point
Copy the full SHA 65ae2c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4d5dcd - Browse repository at this point
Copy the full SHA b4d5dcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 624e3b0 - Browse repository at this point
Copy the full SHA 624e3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41df99d - Browse repository at this point
Copy the full SHA 41df99dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09e526b - Browse repository at this point
Copy the full SHA 09e526bView commit details -
Extracted validation variant common code into internal function
and renamed tests for more consistency
Configuration menu - View commit details
-
Copy full SHA for e38577b - Browse repository at this point
Copy the full SHA e38577bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 456fafd - Browse repository at this point
Copy the full SHA 456fafdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 857d7b8 - Browse repository at this point
Copy the full SHA 857d7b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56973d3 - Browse repository at this point
Copy the full SHA 56973d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eb0c70 - Browse repository at this point
Copy the full SHA 4eb0c70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 404968b - Browse repository at this point
Copy the full SHA 404968bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ac5b99 - Browse repository at this point
Copy the full SHA 6ac5b99View commit details -
Configuration menu - View commit details
-
Copy full SHA for abc8e8d - Browse repository at this point
Copy the full SHA abc8e8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f80b5b4 - Browse repository at this point
Copy the full SHA f80b5b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 011b45d - Browse repository at this point
Copy the full SHA 011b45dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ddf06 - Browse repository at this point
Copy the full SHA 76ddf06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c7dd6a - Browse repository at this point
Copy the full SHA 2c7dd6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6205109 - Browse repository at this point
Copy the full SHA 6205109View commit details