Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured validation results #1104

Merged
merged 124 commits into from
Oct 28, 2022
Merged

Structured validation results #1104

merged 124 commits into from
Oct 28, 2022

Commits on Oct 27, 2022

  1. Define ValidationResult class

    jwodder authored and TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    696e7fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    037dc5e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3bc01ba View commit details
    Browse the repository at this point in the history
  4. Debugging

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    43ab1f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1f88e4e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e8e4b7 View commit details
    Browse the repository at this point in the history
  7. comment for review

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8561215 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f082382 View commit details
    Browse the repository at this point in the history
  9. Review comments

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dd77af2 View commit details
    Browse the repository at this point in the history
  10. Fixed test log path

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    aefb337 View commit details
    Browse the repository at this point in the history
  11. BIDS root detection

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    1c8ddd3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    cb6d494 View commit details
    Browse the repository at this point in the history
  13. removed comment lines

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e2b21ed View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8af720a View commit details
    Browse the repository at this point in the history
  15. Processing input path type

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ea4e790 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    db175a2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a90c99a View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    3304b45 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    2a9377e View commit details
    Browse the repository at this point in the history
  20. Debugging windows tests

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6a0875b View commit details
    Browse the repository at this point in the history
  21. Typing fixes

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    4f248b9 View commit details
    Browse the repository at this point in the history
  22. Trying more typing fixes

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    a564d0d View commit details
    Browse the repository at this point in the history
  23. Debugging typing

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    cc57bfc View commit details
    Browse the repository at this point in the history
  24. Removed unneeded module

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    15e1cfb View commit details
    Browse the repository at this point in the history
  25. Use assert to ensure that Optional becomes non-optional for type chec…

    …king
    
    also used more descriptive "result" variable instead of "i". We contemplated some other
    name (like vrs - for "validation results") but it was not liked
    yarikoptic authored and TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    89a070a View commit details
    Browse the repository at this point in the history
  26. Further corrected type

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    fe238b6 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    25194ee View commit details
    Browse the repository at this point in the history
  28. Type correction

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e630fb8 View commit details
    Browse the repository at this point in the history
  29. Update error tests

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    72f47a0 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    b51e92e View commit details
    Browse the repository at this point in the history
  31. Debug assertion error fix

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    94a1793 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    ec59dad View commit details
    Browse the repository at this point in the history
  33. Using correct fixture

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    43e17e9 View commit details
    Browse the repository at this point in the history
  34. Disabled debugging code

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    4f2e4ae View commit details
    Browse the repository at this point in the history
  35. Debug assertion error

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    bf5c0f1 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    697b24d View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    bb52d56 View commit details
    Browse the repository at this point in the history
  38. Windows debugging

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ee9492a View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    c828628 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    2f1c6a7 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    155e557 View commit details
    Browse the repository at this point in the history
  42. Removed debugging code

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f30ad99 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    676cbc3 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    9a8861b View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    74cc797 View commit details
    Browse the repository at this point in the history
  46. Fixed cmd_validate tests

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    db6a81f View commit details
    Browse the repository at this point in the history
  47. Fixed report path test

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    715f70e View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    fb5847c View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    e0027c3 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    453cd65 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    786729a View commit details
    Browse the repository at this point in the history
  52. Fixed typing

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    d0070bd View commit details
    Browse the repository at this point in the history
  53. Correcting type

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    b205aaf View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    d04f4bd View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    7d21f4e View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    4ba4b7b View commit details
    Browse the repository at this point in the history
  57. Global import

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    23e54be View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    28e7374 View commit details
    Browse the repository at this point in the history
  59. Dropped unused import

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    3702eac View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    2d9723c View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    61e5d3a View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    1711354 View commit details
    Browse the repository at this point in the history
  63. Removed redundant code

    and black fixes
    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    122581a View commit details
    Browse the repository at this point in the history
  64. No placeholder metadata

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e25375b View commit details
    Browse the repository at this point in the history
  65. Unified error reporting across validation types

    also removed part of error reporting which was reporting valid files,
    let me know if you need it back.
    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e292718 View commit details
    Browse the repository at this point in the history
  66. Improve style

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c4a36ca View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    cf34de3 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    e363670 View commit details
    Browse the repository at this point in the history
  69. Corrected warning color

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6a56acd View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    b4ad1bc View commit details
    Browse the repository at this point in the history
  71. RF+BF: address circular import, unify more of validations into Valida…

    …tionResults
    
    TODO: pretty much go through all other instances were "str" is returned for an
    error.  Most of them could be caught up via   `tox -e typing`  or just inspecting
    other code paths.
    
    We also raised following concerns/topics for possible future development
    - do not return error structs for exception handling where we catch
      errors from opening files etc.  But may be there was a reason why
      we decided to work with it this way instead of just handling exceptions.
    - there is .location (within .nwb / hdf5 file) to point more specifically
      within nwb file internal structure.  We need to provide location for that
      in our data structure. But as we have asset_paths, we might want to do that
      as a dict.
    yarikoptic authored and TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    de27873 View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    6b7e680 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    ccf9491 View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    b3106f4 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    49c9a0a View commit details
    Browse the repository at this point in the history
  76. Corrected function return

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    9861be1 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    f387998 View commit details
    Browse the repository at this point in the history
  78. Trying to fix types

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    04ee73c View commit details
    Browse the repository at this point in the history
  79. Type fixing

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    d161b46 View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    482246a View commit details
    Browse the repository at this point in the history
  81. Further type fixes

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    1691547 View commit details
    Browse the repository at this point in the history
  82. Configuration menu
    Copy the full SHA
    889d2e7 View commit details
    Browse the repository at this point in the history
  83. Fixed more typing errors

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dd03eb5 View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    b2f4c2e View commit details
    Browse the repository at this point in the history
  85. Further typing fixes

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0d77a0d View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    e263bf4 View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    8b58dce View commit details
    Browse the repository at this point in the history
  88. Fixed syntax

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f2f577d View commit details
    Browse the repository at this point in the history
  89. Configuration menu
    Copy the full SHA
    5c1890c View commit details
    Browse the repository at this point in the history
  90. No more typing errors

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e30809d View commit details
    Browse the repository at this point in the history
  91. Removed unused imports

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    87048c7 View commit details
    Browse the repository at this point in the history
  92. Configuration menu
    Copy the full SHA
    d4b35b4 View commit details
    Browse the repository at this point in the history
  93. Configuration menu
    Copy the full SHA
    acd78b7 View commit details
    Browse the repository at this point in the history
  94. Configuration menu
    Copy the full SHA
    cc2ad26 View commit details
    Browse the repository at this point in the history
  95. Configuration menu
    Copy the full SHA
    b5e16b1 View commit details
    Browse the repository at this point in the history
  96. Standardized dandi import

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    9f49cc9 View commit details
    Browse the repository at this point in the history
  97. Configuration menu
    Copy the full SHA
    382c3ae View commit details
    Browse the repository at this point in the history
  98. Configuration menu
    Copy the full SHA
    8d71483 View commit details
    Browse the repository at this point in the history
  99. Configuration menu
    Copy the full SHA
    2d4e284 View commit details
    Browse the repository at this point in the history
  100. Configuration menu
    Copy the full SHA
    2c8d034 View commit details
    Browse the repository at this point in the history
  101. Configuration menu
    Copy the full SHA
    80db60e View commit details
    Browse the repository at this point in the history
  102. Configuration menu
    Copy the full SHA
    af48872 View commit details
    Browse the repository at this point in the history
  103. Removed deprecated comment

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    15ce3c7 View commit details
    Browse the repository at this point in the history
  104. Configuration menu
    Copy the full SHA
    8c430f6 View commit details
    Browse the repository at this point in the history
  105. Standardized CLI NWB validator wrt BIDS validator draft and added tests

    Still using 2 separate functions, merging of validation functions best
    for subsequent PR
    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6348f64 View commit details
    Browse the repository at this point in the history
  106. Configuration menu
    Copy the full SHA
    ed5f353 View commit details
    Browse the repository at this point in the history
  107. Configuration menu
    Copy the full SHA
    65ae2c9 View commit details
    Browse the repository at this point in the history
  108. Configuration menu
    Copy the full SHA
    b4d5dcd View commit details
    Browse the repository at this point in the history
  109. Configuration menu
    Copy the full SHA
    624e3b0 View commit details
    Browse the repository at this point in the history
  110. Configuration menu
    Copy the full SHA
    41df99d View commit details
    Browse the repository at this point in the history
  111. Configuration menu
    Copy the full SHA
    09e526b View commit details
    Browse the repository at this point in the history
  112. Extracted validation variant common code into internal function

    and renamed tests for more consistency
    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e38577b View commit details
    Browse the repository at this point in the history
  113. Configuration menu
    Copy the full SHA
    456fafd View commit details
    Browse the repository at this point in the history
  114. Configuration menu
    Copy the full SHA
    857d7b8 View commit details
    Browse the repository at this point in the history
  115. Linting fixes

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    56973d3 View commit details
    Browse the repository at this point in the history
  116. Configuration menu
    Copy the full SHA
    4eb0c70 View commit details
    Browse the repository at this point in the history
  117. Type annotations

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    404968b View commit details
    Browse the repository at this point in the history
  118. Fixed typing

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6ac5b99 View commit details
    Browse the repository at this point in the history
  119. Configuration menu
    Copy the full SHA
    abc8e8d View commit details
    Browse the repository at this point in the history
  120. Fixes proposed by Yaro

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f80b5b4 View commit details
    Browse the repository at this point in the history
  121. Configuration menu
    Copy the full SHA
    011b45d View commit details
    Browse the repository at this point in the history
  122. Orthography

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    76ddf06 View commit details
    Browse the repository at this point in the history
  123. Configuration menu
    Copy the full SHA
    2c7dd6a View commit details
    Browse the repository at this point in the history
  124. Type fix

    TheChymera committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6205109 View commit details
    Browse the repository at this point in the history