Support DANDI:<ID>/draft and stop using identifiers.org for any of the DANDI: URIs #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satra
reviewed
Jul 15, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 72 72
Lines 9261 9265 +4
=======================================
+ Hits 8185 8189 +4
Misses 1076 1076
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@yarikoptic This PR should also include an update to |
There is no point to go through identifiers.org for DANDI:ID if we are not to go for DANDI:ID/draft. Hence - just parse into the "dandi" instance and for that lower case it after matching in the group. I do not think that should have negative effect
yarikoptic
force-pushed
the
bf-dandi-draft
branch
from
501aa79
to
ae5ff56
Compare
thanks! adjusted in 49e1d13 |
jwodder
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1065
If we are to support
DANDI:<ID>/draftwhich cannot go through the identifiers.org, I saw no reason to go through identifiers.org for anyDANDI:<ID>since that, if anything, could only introduce inconsistency.I have left also initial version which creates a dedicated rule for
/draftversion in a separate commit "just in case".@satra -- please review to agree that there would be no reason to go through identifiers.org
@jwodder -- please review for code changes etc