ENH: delete - allow to specify --force in CLI #1001
Conversation
internal implementation already had that option, so we just needed to pass it through Closes #993
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1001 +/- ##
===========================================
+ Coverage 64.85% 87.48% +22.63%
===========================================
Files 64 64
Lines 8109 8110 +1
===========================================
+ Hits 5259 7095 +1836
+ Misses 2850 1015 -1835
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docs/source/cmdline/delete.rst
Outdated
| resources are instead simply silently ignored. | ||
| resources are instead simply silently ignored | ||
|
|
||
| .. option:: --force |
There was a problem hiding this comment.
Please place this before --instance so that the options are in alphabetical order.
There was a problem hiding this comment.
oh -- didn't know that there is such convention. So ATM we have 3 orders -- one in delete python API, another in click interface (debug options go last), and then yet another in docs (sorted alphabetically). IMHO that is suboptimal since again becomes a surprise while switching between interfaces and documentation. But for now, for consistency, moved it up as requested (force pushed doc changing commit).
Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
yarikoptic
force-pushed
the
enh-delete-force
branch
from
e9171fa
to
a9370c9
Compare
|
🚀 PR was released in |
internal implementation already had that option, so we just needed
to pass it through
Closes #993