Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload should fail if client uses outdated schema #722

Closed
yarikoptic opened this issue Jul 21, 2021 · 0 comments · Fixed by #724
Closed

upload should fail if client uses outdated schema #722

yarikoptic opened this issue Jul 21, 2021 · 0 comments · Fixed by #724
Assignees

Comments

@yarikoptic
Copy link
Member

I was blindly sure that we consult API about the version of the schema it expects, but apparently I was wrong since I cannot find any trace of that!?

/info endpoint, e.g. https://api-staging.dandiarchive.org/api/info/?format=json provides schema_version. dandi-cli should not even attempt upload if the schema version it uses doesn't match exactly ATM (I would prefer allowing for higher .patch being allowed, but I think neither dandischema nor dandi-api support that ATM, ref: e.g. dandi/dandi-schema#22 )

I think absence of such prevention mechanism is what resulted in e.g. #719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants