Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pin nightly version to 2022-11-01 #435

Closed
wants to merge 1 commit into from

Conversation

tarcieri
Copy link
Contributor

A pinned nightly may potentially work around the build failures we're experiencing due to build scripts using SIMD features:

#433 (comment)

@tarcieri tarcieri requested a review from rozbb November 13, 2022 20:20
A pinned nightly may potentially work around the build failures we're
experiencing due to build scripts using SIMD features:

#433 (comment)
@tarcieri
Copy link
Contributor Author

tarcieri commented Nov 13, 2022

This seems to have recently popped up, so it seems that LLVM might be auto-vectorizing some code in the build script it previously didn't used to.

Hopefully pinning the nightly version provides a band-aid and also keeps the build reproducibly green. However it doesn't actually solve the problem of the build failing on missing AVX intrinsics.

@rozbb
Copy link
Contributor

rozbb commented Nov 14, 2022

I can't seem to replicate the build error on my x86-64 machine. On release/4.0 I'm running cargo +nightly test --features "simd_backend" Should that produce an error?

@tarcieri
Copy link
Contributor Author

tarcieri commented Nov 14, 2022

It appears to be dying when these RUSTFLAGS are used:

RUSTFLAGS="-C target_feature=+avx512ifma"

I managed to reproduce it locally:

$ RUSTFLAGS="-C target_feature=+avx512ifma" cargo +nightly test --features "simd_backend"
   Compiling autocfg v1.1.0
   [...]
   Compiling ciborium-ll v0.2.0
error: failed to run custom build command for `proc-macro2 v1.0.47`

Caused by:
  process didn't exit successfully: `/Users/bascule/src/dalek-cryptography/curve25519-dalek/target/debug/build/proc-macro2-1ea3ba4a89c1184f/build-script-build` (signal: 4, SIGILL: illegal instruction)

@tarcieri
Copy link
Contributor Author

Hmm, it seems while this nightly version "fixed" the issue in CI, it's still failing locally for me

@rozbb
Copy link
Contributor

rozbb commented Nov 14, 2022

Same, even after a cargo clean

@rozbb
Copy link
Contributor

rozbb commented Nov 14, 2022

Not for me 😕

@tarcieri
Copy link
Contributor Author

Might've found a workaround: #436

@tarcieri
Copy link
Contributor Author

I think #436 is working. Closing this.

@tarcieri tarcieri closed this Nov 14, 2022
@tarcieri tarcieri deleted the pin-nightly-version branch November 14, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants