support suggested fixes by analyzing a diff #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVilgelm
force-pushed
the
fix-146-suggested-fixes
branch
3 times, most recently
from
d5a859f
to
6307ed6
Compare
daixiang0
reviewed
Mar 9, 2023
Added `GetSuggestedFix` function creates unified diff for `unmodifiedFile` and `formattedFile`. Then analyzes the diff and creates `analysis.SuggestedFix` if needed. The Analyzer checks the result of `GetSuggestedFix` function and reports as `analysis.Diagnostic`. Fix daixiang0#146 Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
SVilgelm
force-pushed
the
fix-146-suggested-fixes
branch
from
6307ed6
to
3734c08
Compare
daixiang0
reviewed
Mar 9, 2023
daixiang0
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
GetSuggestedFixfunction creates unified diff forunmodifiedFileandformattedFile.Then analyzes the diff and creates
analysis.SuggestedFixif needed.The Analyzer checks the result of
GetSuggestedFixfunction and reports asanalysis.Diagnostic.Removed the
inspect.Analyzerdependency since it is not used, but requires extra workFix #146