Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor waku/client (technically breaking) #708

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented May 13, 2024

for v0.21.0.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview May 16, 2024 0:11am

Copy link

codesandbox-ci bot commented May 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review May 13, 2024 14:04
@dai-shi dai-shi merged commit 5f7dcbb into main May 16, 2024
28 checks passed
@dai-shi dai-shi deleted the waku-client-for-actions branch May 16, 2024 01:13
@dai-shi dai-shi mentioned this pull request May 20, 2024
dai-shi added a commit that referenced this pull request May 20, 2024
follow up #708 which wasn't enough. related: #714
dai-shi added a commit that referenced this pull request May 27, 2024
dai-shi added a commit that referenced this pull request May 27, 2024
#708 changed the code, but type check doesn't work for this code.
It would be nice to have a better way somehow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant