fix: hmr plugin with async component (with ssr, dev only) #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dai-shi
commented
Jan 22, 2024
| }; | ||
|
|
||
| const ServerMessage = async () => { | ||
| await new Promise((resolve) => setTimeout(resolve, 2000)); |
There was a problem hiding this comment.
We need this to reproduce the bug.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 649b49b:
|
dai-shi
commented
Jan 22, 2024
| @@ -33,7 +33,7 @@ export function rscHmrPlugin(): Plugin { | |||
| return [ | |||
| { | |||
| tag: 'script', | |||
| attrs: { type: 'module' }, | |||
| attrs: { type: 'module', async: true }, | |||
There was a problem hiding this comment.
By default it's "defer" and the script isn't evaluated during HTML streaming.
cc @Aslemammad
There was a problem hiding this comment.
niceeee, i love that solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.