Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update bin to fix command not found when run examples #101

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

EasonYou
Copy link
Contributor

@EasonYou EasonYou commented Jul 7, 2023

What's the issue

When clone the repo at the first time, can not run examples after running pnpm install.
It tells waku: command not found.
If waku link was built in the dir before, it would not warn the error.
image

What's the platform

Run in mac OS 13.2.1 (22D68), Node v18.16.0

How to fix

I found the bin property is corrent, but it can't work
I re-clone the repo and update the bin then run pnpm install, it fixed.
image

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 3:23pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a76192:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this fixes (a bug in pnpm?), but fine to merge. Thanks for your contribution!

@dai-shi dai-shi merged commit 34188f0 into dai-shi:main Jul 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants