[dagster webserver] fix websockets on py3.11 #19328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
alangenfeld
force-pushed
the
al/01-19-_dagster_webserver_fix_websockets_on_py3.11
branch
from
3b46830
to
de3f125
Compare
prha
approved these changes
Jan 19, 2024
alangenfeld
deleted the
al/01-19-_dagster_webserver_fix_websockets_on_py3.11
branch
PedramNavid
pushed a commit
that referenced
this pull request
Jan 26, 2024
another place effected by python/cpython#100458 the string `<GraphQLWS.PROTOCOL: 'graphql-ws'>` was being sent instead of `graphql-ws` ## How I Tested These Changes added assert to test that would have caught this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another place effected by python/cpython#100458
the string
<GraphQLWS.PROTOCOL: 'graphql-ws'>was being sent instead ofgraphql-wsHow I Tested These Changes
added assert to test that would have caught this