Move unmatching inside second_phase of SR
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing simple examples to fail because the second phase of the algorithm never kicked in. By moving the unmatching, this is avoided, and is fine because of the corollaries in Irving's paper.
|
I am expecting doctests to fail. #126 fixes that issue. Need to add the example tests for SR. |
daffidwilde
added a commit
that referenced
this pull request
Oct 15, 2020
* Fix ipython version to avoid warnings. (#126) * Fix ipython version to avoid warnings. There were some weird warnings coming from an internal `ipython`/`ipykernel` API, causing `pytest-nbval` to fail its tests. So, downgrading `ipython` to 7.10 until that is fixed. Details are available under [this issue](ipython/ipykernel#540). * Fix ipython version in workflow file. * Move unmatching inside `second_phase` of SR (#125) * Move unmatching inside `second_phase` This was causing simple examples to fail because the second phase of the algorithm never kicked in. By moving the unmatching, this is avoided, and is fine because of the corollaries in Irving's paper. * Add example tests from #124 * Checkout CI file from dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing simple examples to fail because the second phase of the
algorithm never kicked in. By moving the unmatching, this is avoided,
and is fine because of the corollaries in Irving's paper.
Thanks to @MartinMohlenkamp on #124 for raising this issue.