Skip to content

Commit

Permalink
Fix ipython version to avoid warnings. (#126)
Browse files Browse the repository at this point in the history
* Fix ipython version to avoid warnings.

There were some weird warnings coming from an internal
`ipython`/`ipykernel` API, causing `pytest-nbval` to fail its tests. So,
downgrading `ipython` to 7.10 until that is fixed.

Details are available under
[this issue](ipython/ipykernel#540).

* Fix ipython version in workflow file.
  • Loading branch information
daffidwilde authored Oct 15, 2020
1 parent b5391db commit 77e63cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:
- uses: actions/checkout@master
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v1.1.1
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand All @@ -31,6 +31,7 @@ jobs:
python -m pip install -q --no-cache-dir sphinx sphinx_rtd_theme
python -m pip install -q --no-cache-dir nbval sphinxcontrib-bibtex
python -m pip install -q --no-cache-dir matplotlib pandas PyYAML
python -m pip install -q --no-cache-dir ipython==7.10
python -m pip list
- name: Lint with Black
if: matrix.python-version == 3.7 && matrix.os == 'ubuntu-latest'
Expand Down
2 changes: 1 addition & 1 deletion docs/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ dependencies:
- matplotlib>=3
- numpy>=1.16
- pandas>=0.24
- ipython>=7.6
- ipython=7.10
- python>=3.6
- pip>=19
- sphinx=2.4.0
Expand Down

0 comments on commit 77e63cb

Please sign in to comment.