fix for FundingCircle#262

dacreify · Jun 29, 2020 · 8e9f06a · 8e9f06a
1 parent 04f654f
commit 8e9f06a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/jackdaw/streams/interop.clj b/src/jackdaw/streams/interop.clj
@@ -40,9 +40,12 @@
   (Serialized/with key-serde value-serde))
 
 (defn topic->materialized [{:keys [topic-name key-serde value-serde]}]
-  (cond-> (Materialized/as ^String topic-name)
-    key-serde (.withKeySerde key-serde)
-    value-serde (.withValueSerde value-serde)))
+  (if topic-name
+    (cond-> (Materialized/as ^String topic-name)
+            key-serde (.withKeySerde key-serde)
+            value-serde (.withValueSerde value-serde))
+    (Materialized/with key-serde
+                       value-serde)))
 
 (defn suppress-config->suppressed
   [{:keys [max-records max-bytes until-time-limit-ms]}]

diff --git a/test/jackdaw/streams/interop_test.clj b/test/jackdaw/streams/interop_test.clj
@@ -0,0 +1,16 @@
+(ns jackdaw.streams.interop-test
+  (:require
+    [clojure.test :refer :all]
+    [jackdaw.streams.interop :as interop])
+  (:import
+    (org.apache.kafka.common.serialization
+      Serdes)))
+
+(deftest topic->materialized-test
+  (testing "materialized with serde only doesn't smoke"
+    (is (interop/topic->materialized {:key-serde (Serdes/String)
+                                      :value-serde (Serdes/String)})))
+  (testing "materialized with topic name and serde doesn't smoke"
+    (is (interop/topic->materialized {:key-serde (Serdes/String)
+                                      :value-serde (Serdes/String)}))))
+