Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving search to it's own file. #1288

Closed

Conversation

monksy
Copy link

@monksy monksy commented Feb 6, 2024

Speed up search and reduce page sizes.

#1284

Please note that if you are trying to update your website, this is the wrong place to do so. Please carefully follow the Beautiful Jekyll instructions (found at https://github.com/daattali/beautiful-jekyll#readme) and make sure you submit changes to your version of the project.

If your intention is to submit a Pull Request, please describe what your pull request achieves.

Thank you!

Speed up search and reduce page sizes.

daattali#1284
@monksy
Copy link
Author

monksy commented Feb 6, 2024

image

@monksy
Copy link
Author

monksy commented Feb 14, 2024

@daattali

@daattali
Copy link
Owner

Thanks for the suggestion! I've been thinking about this for a while and while I do really agree with the idea, there's one problem that makes it difficult for me to accept this PR.
Anyone who uses this theme as a remote_them or a ruby gem will not have access to the json file you created, and they'll be required to manually add that file. There are currently only a handful of files that behave this way, and I try to stay away from that as much as possible, because each one of these cases adds more friction. Do you think there's a way to achieve the same goal but without creating a file that users will have to create manually?

@daattali
Copy link
Owner

@monksy ping :)

@ccorsi
Copy link

ccorsi commented Aug 19, 2024

@daattali I agree with you that this is a good idea but the implementation requires a better solution. I think that the generated json file should be placed within the assets directory, specifically within a data subdirectory of the assets directory. Since your theme includes this as part of your distribution then this solution will work when using the gem or remote_theme feature.

@daattali
Copy link
Owner

Implemented in e6fc968

Thanks @ccorsi for your help

@daattali daattali closed this Sep 18, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants