Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUSH_NOTIFICATIONS permission to AndroidManifest.xml for wearos #203

Merged

Conversation

kavishdevar
Copy link
Contributor

Fixes #154 by adding the required uses-permission for push notifications tag in AndroidManifest.xml for wearos.

@kavishdevar kavishdevar changed the title Add PUSH_NOTIFICATIONS permissions to AndroidManifest.xml for wearos Add PUSH_NOTIFICATIONS permission to AndroidManifest.xml for wearos May 20, 2024
@d4rken
Copy link
Member

d4rken commented May 21, 2024

Have you tested this? There is no PUSH_NOTIFICATIONS permission in Android.

@kavishdevar
Copy link
Contributor Author

kavishdevar commented May 21, 2024

This permission was introduced in API Level 33 (Android 13). Refer https://developer.android.com/develop/ui/views/notifications/notification-permission

I have tested it on my Galaxy Watch 6 running WearOS 4 (Android 13)

@rcky844
Copy link

rcky844 commented Jun 26, 2024

This permission was introduced in API Level 33 (Android 13). Refer https://developer.android.com/develop/ui/views/notifications/notification-permission

I have tested it on my Galaxy Watch 6 running WearOS 4 (Android 13)

I think you've got the name of it wrong, the page states:
android.permission.POST_NOTIFICATIONS

@kavishdevar
Copy link
Contributor Author

Oh, my bad, fixed the typo now.

I actually buit a few builds locally and then forked the repository for the PR. So, I didn't actually test the code that I pushed... Apologies!

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@d4rken d4rken merged commit 65a7b19 into d4rken-org:main Jun 26, 2024
7 checks passed
@kavishdevar kavishdevar deleted the wearos-notification-permission-fix branch June 26, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use on Samsung 5 watch
3 participants