Parking Patch #49
Merged
Parking Patch #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CSVs to reference path locations per the request of CL at Esri. This seems to work on a PC test in CityEngine, but the fraction of Vans might be more explicit or half . Thank for suggestions!
New vehicles in Esri.lib are superior and are supported by the asset CSV. Delete old assets.
Use complete folder for assets if the Asset_Metadata.csv is present. This will help force a transition. Fix projection of rail transit pavement. Simplify rule. TODO to fix microtransit inclusion in cars used.
Reclassify transit connect vehicle as microtransit.
These assets are in Esri Lib and better represented through the Asset CSV. There is some clunky behavior when selecting sidewalks and streets, but the enums do work as intended.
Based on some suggestions of Esri, I am trying to use alignScopeToGeometryBBOX for parking rather than to geometry. This could be in theory applied in other areas, but the potential impacts are unclear. This seems to provide better performance for parking spaces specifically, and the pattern used here would likely work elsewhere. Angle issues still exist at curbside drop off or longer polygons, but this seems to work better. Might for others as well that are clearly rectangular shapes.
Based on some suggestions of Esri, I am trying to use alignScopeToGeometryBBOX for parking rather than to geometry. This could be in theory applied in other areas, but the potential impacts are unclear. This seems to provide better performance for parking spaces specifically, and the pattern used here would likely work elsewhere. Angle issues still exist at curbside drop off or longer polygons, but this seems to work better. Might for others as well that are clearly rectangular shapes.
Parking is oriented in the wrong direction with align to bbox on straight streets. This addresses that but might keep some of the benefits of bbox alignment. Minor edits to comments to remove special characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On straight streets, align to bbox changed the facing of the streets. This will fix this and keep some of the advantages of alignToGeometryBBOX.